Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix ActionDispatchSpy#render_exception for Rails 7.1 #1423

Merged

Conversation

jclusso
Copy link
Contributor

@jclusso jclusso commented Nov 3, 2023

In Rails 7.1 render_exception was changed to take an ActionDispatch::ExceptionWrapper instead of an Exception. I've added support for the new way while keeping support for pre 7.1.

Copy link
Contributor

@dalibor dalibor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estolfo Could we get this released, please?

@janko
Copy link

janko commented Nov 13, 2023

We're experiencing this issue as well, in the form of undefined method 'cause' for #<ActionDispatch::ExceptionWrapper...> errors in our error monitoring service.

In Rails 7.1 `render_exception` was changed to take an ActionDispatch::ExceptionWrapper instead of an Exception. I've added support for the new way while keeping support for pre 7.1.
@picandocodigo picandocodigo force-pushed the fix_action_dispatch_spy_render_exception branch from 4693a37 to 53851c3 Compare November 24, 2023 12:56
@picandocodigo
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@picandocodigo picandocodigo merged commit 9612945 into elastic:main Nov 24, 2023
@jclusso jclusso deleted the fix_action_dispatch_spy_render_exception branch November 25, 2023 15:46
@jclusso jclusso restored the fix_action_dispatch_spy_render_exception branch November 28, 2023 15:28
@jclusso jclusso deleted the fix_action_dispatch_spy_render_exception branch November 28, 2023 15:42
@assembler
Copy link

+1 for releasing this

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants