Skip to content

Optimize batch usage #157

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented Apr 3, 2024

Details are in https://github.com/elastic/apm-aggregation-service/issues/366#issuecomment-1846936193

Requires cockroachdb/pebble#3139

More benchmarking required before ready for merging.

@lahsivjar lahsivjar force-pushed the batch-optimization branch from 9153032 to 2b0fd76 Compare April 3, 2024 11:20
@kruskall kruskall marked this pull request as ready for review April 22, 2024 08:21
@kruskall kruskall requested a review from a team as a code owner April 22, 2024 08:21
@kruskall
Copy link
Member

@lahsivjar I've updated the PR to use our fork. Does this need more benchmarks ? Can we merge this ?

@lahsivjar
Copy link
Contributor Author

Does this need more benchmarks ? Can we merge this ?

The benchmarks shared were done quite a while ago. We should do another round of benchmarking first before proceeding further.

@kruskall
Copy link
Member

Thanks @lahsivjar 🙇

Could you run the benchmarks again ?

@lahsivjar lahsivjar self-assigned this Apr 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants