Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

do not encode some viz attributes #1018

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Conversation

graphaelli
Copy link
Member

unpack_dashboards will now handle it through make update

fixes #1017

unpack_dashboards will now handle it through make update
@graphaelli
Copy link
Member Author

tested this manually by:

confirm bug:

make update apm-server
ln -s _meta/kibana.generated
./apm-server -E setup.dashboards.enabled=true

open dashboards, see they don't load. confirm saved objects are double json encoded

confirm fix:
repeat with this change and confirm all is well.

This would be a good one for https://github.com/elastic/apm-integration-testing.

@graphaelli graphaelli requested a review from simitt June 19, 2018 16:21
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@graphaelli graphaelli merged commit 46bc977 into elastic:master Jun 20, 2018
@graphaelli graphaelli deleted the fix-viz branch June 20, 2018 11:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualizations broken
3 participants