fix: use a single source of truth for the go version (backport #15583) #15606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
go version is defined in two places: go.mod and .go-version they often get out of sync and it's not clear which is used where. CI is using the version defined in go.mod which might be outdated compared to .go-version. bump go version in go.mod and ensure scripts are using it consistently remove old jenkins scripts (cherry picked from commit c24a1cb)
2 tasks
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 1353b25 |
kruskall
approved these changes
Feb 7, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
go version is defined in two places: go.mod and .go-version they often get out of sync and it's not clear which is used where. CI is using the version defined in go.mod which might be outdated compared to .go-version.
bump go version in go.mod and ensure scripts are using it consistently
remove old jenkins scripts
.go-versionis kept around because it's still used in one place: the version bump automation. I plan to raise an issue to just create a workflow that runsmake update-go-versionsince we already handle everything in a make task.Checklist
For functional changes, consider:
How to test these changes
Related issues
Related to #15581
This is an automatic backport of pull request #15583 done by Mergify.