-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Test filebeat/metricbeat modules list #87
Test filebeat/metricbeat modules list #87
Conversation
Test that the `filebeat modules list` and `metricbeat modules list` commands are working. Relates elastic/beats#7488 elastic/beats#8105
This should fail for Metricbeat on Linux until elastic/beats#8105 is merged. Both the Filebeat and Metricbeat+Windows changes should be running successfully. |
This would catch the bug we had, but I'm thinking to also do a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@tsg agree we should add more and run enable/disable
. Should we merge this PR and do it in a follow up?
We have those tests in the product's system tests. Do you still want to add them here as well? |
Between that and the package tests and the |
I opened a separate issue for the enable/disable testing enhancement. See #88. |
@andrewkroh Want to merge it yourself in case @tsg gives his 👍 ? :-) |
Test that the
filebeat modules list
andmetricbeat modules list
commands are working.Relates elastic/beats#7488 elastic/beats#8105