Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test filebeat/metricbeat modules list #87

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

andrewkroh
Copy link
Member

Test that the filebeat modules list and metricbeat modules list commands are working.

Relates elastic/beats#7488 elastic/beats#8105

Test that the `filebeat modules list` and `metricbeat modules list` commands are working.

Relates elastic/beats#7488 elastic/beats#8105
@andrewkroh
Copy link
Member Author

This should fail for Metricbeat on Linux until elastic/beats#8105 is merged. Both the Filebeat and Metricbeat+Windows changes should be running successfully.

@tsg
Copy link
Contributor

tsg commented Aug 28, 2018

This would catch the bug we had, but I'm thinking to also do a modules enable command and check that modules list had enabled that module? This would cover a little bit more from the Kibana tutorials.

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tsg agree we should add more and run enable/disable. Should we merge this PR and do it in a follow up?

@andrewkroh
Copy link
Member Author

We have those tests in the product's system tests. Do you still want to add them here as well?

@tsg
Copy link
Contributor

tsg commented Aug 28, 2018

Between that and the package tests and the module list from here we're probably well covered, so maybe we don't need it. If it's very simple to add them, it might still be worth it to do it, but I'm good to do it in a future PR.

@andrewkroh
Copy link
Member Author

I opened a separate issue for the enable/disable testing enhancement. See #88.

@ruflin
Copy link
Contributor

ruflin commented Aug 29, 2018

@andrewkroh Want to merge it yourself in case @tsg gives his 👍 ? :-)

@andrewkroh andrewkroh merged commit 87422ae into elastic:master Aug 29, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants