Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#29747: Fix Add Network Direction processor #29751

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Jan 9, 2022

What does this PR do?

Fix #29747

Why is it important?

incorrect fields

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 9, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 9, 2022

This pull request does not have a backport label. Could you fix it @legoguy1000? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 9, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-10T22:12:11.773+0000

  • Duration: 105 min 37 sec

  • Commit: cdd5d92

Test stats 🧪

Test Results
Failed 0
Passed 47839
Skipped 4284
Total 52123

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 10, 2022
@efd6
Copy link
Contributor

efd6 commented Jan 10, 2022

/test

@mergify
Copy link
Contributor

mergify bot commented Jan 10, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 29747-fix-network-direction upstream/29747-fix-network-direction
git merge upstream/master
git push upstream 29747-fix-network-direction

@jsoriano
Copy link
Member

Is there something pending to merge this PR? 🚀

@andrewkroh andrewkroh merged commit 56b227d into elastic:master Feb 1, 2022
@andrewkroh andrewkroh added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify libbeat and removed backport-skip Skip notification from the automated backport with mergify labels Feb 1, 2022
mergify bot pushed a commit that referenced this pull request Feb 1, 2022
Fix Add Network Direction processor field with dot in name.

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
(cherry picked from commit 56b227d)
mergify bot pushed a commit that referenced this pull request Feb 1, 2022
Fix Add Network Direction processor field with dot in name.

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
(cherry picked from commit 56b227d)
@legoguy1000 legoguy1000 deleted the 29747-fix-network-direction branch February 1, 2022 02:48
andrewkroh added a commit that referenced this pull request Mar 15, 2022
Fix Add Network Direction processor field with dot in name.

(cherry picked from commit 56b227d)

Co-authored-by: Alex Resnick <adr8292@gmail.com>
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify libbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libbeat] add_network_direction creates field name that contains a dot
6 participants