Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Containerd populate ecs fields #30267

Conversation

MichaelKatsoulis
Copy link
Contributor

After new container ECS fields get GA (elastic/ecs#1747) containerd module need to start populating those fields.

The new fields are

container.cpu.usage
container.memory.usage
container.disk.write.bytes
container.disk.read.bytes
These fields map to containerd fields:

containerd.cpu.usage.total.pct by cpu metricset
containerd.memory.usage.pct by memory metricset
containerd.blkio.write.bytes by blkio metricset
containerd.blkio.read.bytes by blkio metricset

respectively.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 8, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 8, 2022

This pull request does not have a backport label. Could you fix it @MichaelKatsoulis? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 8, 2022
@MichaelKatsoulis MichaelKatsoulis self-assigned this Feb 8, 2022
@MichaelKatsoulis MichaelKatsoulis marked this pull request as draft February 8, 2022 10:33
@MichaelKatsoulis MichaelKatsoulis added the Team:Integrations Label for the Integrations team label Feb 8, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 8, 2022
@MichaelKatsoulis MichaelKatsoulis added the backport-v8.1.0 Automated backport with mergify label Feb 8, 2022
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Feb 8, 2022
@tetianakravchenko
Copy link
Contributor

@MichaelKatsoulis This PR seems to fully duplicate #30181, should then #30181 be closed, or?

@MichaelKatsoulis
Copy link
Contributor Author

@MichaelKatsoulis This PR seems to fully duplicate #30181, should then #30181 be closed, or?

This one is for containerd module. #30181 is for Kubernetes

@tetianakravchenko
Copy link
Contributor

closing it in favor of #31025

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport-v8.1.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants