Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove kibana 5 dashboards and index patterns #8927

Merged
merged 5 commits into from
Nov 19, 2018

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Nov 5, 2018

Remove kibana 5 dashboards and index patterns generation for 7.0.

@jsoriano jsoriano added v7.0.0 discuss Issue needs further discussion. review labels Nov 5, 2018
@jsoriano jsoriano requested a review from ruflin November 5, 2018 15:22
@ruflin
Copy link
Contributor

ruflin commented Nov 6, 2018

Probably worth a changelog entry for both dev and non dev changelog?

@ruflin
Copy link
Contributor

ruflin commented Nov 6, 2018

You probably also have to adjust the index_pattern generator.

versionPath = "5"
}
return versionPath
return strconv.Itoa(version.Major)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruflin tests are failing because of this change, according to tests, path should be 6/index-pattern for all versions major to 5, is this correct? should we continue using the generated index patterns for version 6?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Today I would say yes but as far as I heard the structure on the Kibana side might change, so not sure if we need to adapt it. @skh is currently looking into these structure changes from the dashboard perspective.

To move this forward I would say for now lets stick to just 6.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I revert the change here and remove generation for 7.0 by now.

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsg @monicasarbu for awareness.

@jsoriano jsoriano merged commit 48a7397 into elastic:master Nov 19, 2018
@jsoriano jsoriano deleted the remove-kibana-5-dashboards branch November 19, 2018 17:59
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
discuss Issue needs further discussion. review v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants