Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GCP CI - flaky tests fix #1573

Merged
merged 18 commits into from
Feb 4, 2024
Merged

GCP CI - flaky tests fix #1573

merged 18 commits into from
Feb 4, 2024

Conversation

gurevichdmitry
Copy link
Collaborator

@gurevichdmitry gurevichdmitry commented Nov 21, 2023

Summary of your changes

This PR addresses test flakiness resulting from dropped events with more than 1000 fields, as discussed here.

Screenshot/Data

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

@gurevichdmitry gurevichdmitry requested a review from a team as a code owner November 21, 2023 14:48
Copy link

mergify bot commented Nov 21, 2023

This pull request does not have a backport label. Could you fix it @gurevichdmitry? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

Copy link

github-actions bot commented Nov 21, 2023

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 39
⬜ Skipped 1

@gurevichdmitry gurevichdmitry linked an issue Nov 23, 2023 that may be closed by this pull request
Copy link

mergify bot commented Nov 23, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp-ci-update upstream/gcp-ci-update
git merge upstream/main
git push upstream gcp-ci-update

@gurevichdmitry gurevichdmitry marked this pull request as draft December 12, 2023 08:39
Copy link

mergify bot commented Dec 12, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp-ci-update upstream/gcp-ci-update
git merge upstream/main
git push upstream gcp-ci-update

@gurevichdmitry gurevichdmitry marked this pull request as ready for review January 30, 2024 17:21
@gurevichdmitry
Copy link
Collaborator Author

This is the latest successful run with the changes.

Copy link
Collaborator

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gurevichdmitry gurevichdmitry merged commit f504e59 into main Feb 4, 2024
30 checks passed
@gurevichdmitry gurevichdmitry deleted the gcp-ci-update branch February 4, 2024 12:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCP] Fix flaky integration test
2 participants