Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tidy up test data generators #293

Merged
merged 4 commits into from
Sep 10, 2023
Merged

Tidy up test data generators #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb8b96e
test data tidy up
orouz Aug 14, 2023
0171706
keep monitoring asset
orouz Aug 30, 2023
f0b96c3
remove sa test data
orouz Aug 30, 2023
ef6028f
Merge branch 'main' into test_data
orouz Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions bundle/compliance/cis_gcp/rules/cis_1_7/test.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,24 @@ date_within_last_90_days := time.format(time.add_date(time.now_ns(), 0, 0, -2))

date_before_last_90_days := time.format(time.add_date(time.now_ns(), 0, 0, -91))

type := "identity-management"

subType := "gcp-iam-service-account-key"

test_violation {
eval_fail with input as test_data.generate_iam_service_account_key({"validAfterTime": date_before_last_90_days})
eval_fail with input as test_data.generate_gcp_asset(
type, subType,
{"data": {"validAfterTime": date_before_last_90_days}},
{},
)
}

test_pass {
eval_pass with input as test_data.generate_iam_service_account_key({"validAfterTime": date_within_last_90_days})
eval_pass with input as test_data.generate_gcp_asset(
type, subType,
{"data": {"validAfterTime": date_within_last_90_days}},
{},
)
}

test_not_evaluated {
Expand Down
117 changes: 43 additions & 74 deletions bundle/compliance/cis_gcp/test_data.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
package cis_gcp.test_data

generate_iam_policy(members, role) = {
"resource": {
"resource": {},
"iam_policy": {"bindings": [{
"role": role,
"members": members,
}]},
},
"type": "key-management",
"subType": "gcp-iam-service-account",
}

generate_gcp_asset(type, subtype, resource, iam_policy) = {
"resource": {
"resource": resource,
Expand All @@ -21,6 +9,13 @@ generate_gcp_asset(type, subtype, resource, iam_policy) = {
"subType": subtype,
}

generate_iam_policy(members, role) = generate_gcp_asset(
"key-management",
"gcp-iam-service-account",
{},
{"bindings": [{"role": role, "members": members}]},
)

generate_monitoring_asset(log_metrics, alerts) = {
"resource": {
"log_metrics": log_metrics,
Expand All @@ -30,70 +25,44 @@ generate_monitoring_asset(log_metrics, alerts) = {
"subType": "gcp-monitoring",
}

generate_kms_resource(members, rotationPeriod, nextRotationTime, primary) = {
"resource": {
"resource": {"data": {
"nextRotationTime": nextRotationTime,
"rotationPeriod": rotationPeriod,
"primary": primary,
}},
"iam_policy": {"bindings": [{
"role": "roles/cloudkms.cryptoKeyEncrypterDecrypter",
"members": members,
}]},
},
"type": "key-management",
"subType": "gcp-cloudkms-crypto-key",
}
generate_kms_resource(members, rotationPeriod, nextRotationTime, primary) = generate_gcp_asset(
"key-management",
"gcp-cloudkms-crypto-key",
{"data": {"nextRotationTime": nextRotationTime, "rotationPeriod": rotationPeriod, "primary": primary}},
{"bindings": [{"role": "roles/cloudkms.cryptoKeyEncrypterDecrypter", "members": members}]},
)

generate_gcs_resource(members, isBucketLevelAccessEnabled) = {
"resource": {
"resource": {"data": {"iamConfiguration": {"uniformBucketLevelAccess": {"enabled": isBucketLevelAccessEnabled}}}},
"iam_policy": {"bindings": [{
"role": "roles/storage.objectViewer",
"members": members,
}]},
},
"type": "cloud-storage",
"subType": "gcp-storage-bucket",
}
generate_gcs_resource(members, isBucketLevelAccessEnabled) = generate_gcp_asset(
"cloud-storage",
"gcp-storage-bucket",
{"data": {"iamConfiguration": {"uniformBucketLevelAccess": {"enabled": isBucketLevelAccessEnabled}}}},
{"bindings": [{"role": "roles/storage.objectViewer", "members": members}]},
)

generate_bq_resource(config, subType, members) = {
"resource": {
"resource": {"data": {"defaultEncryptionConfiguration": config}},
"iam_policy": {"bindings": [{
"role": "roles/bigquery.dataViewer",
"members": members,
}]},
},
"type": "cloud-storage",
"subType": subType,
}

generate_compute_resource(subType, info) = {
"resource": {"resource": {"data": info}},
"type": "cloud-compute",
"subType": subType,
}
generate_bq_resource(config, subType, members) = generate_gcp_asset(
"cloud-storage",
subType,
{"data": {"defaultEncryptionConfiguration": config}},
{"bindings": [{"role": "roles/bigquery.dataViewer", "members": members}]},
)

generate_iam_service_account_key(resourceData) = {
"resource": {
"resource": {"data": resourceData},
"iam_policy": {},
},
"type": "kidentity-management",
"subType": "gcp-iam-service-account-key",
}
generate_compute_resource(subType, info) = generate_gcp_asset(
"cloud-compute",
subType,
{"data": info},
{},
)

not_eval_resource = {
"resource": {},
"type": "key-management",
"subType": "no-exisitng-type",
}
not_eval_resource = generate_gcp_asset(
"key-management",
"non-existing-subtype",
{},
{},
)

# missing resource.iam_policy
no_policy_resource = {
"resource": {"resource": {}},
"type": "key-management",
"subType": "gcp-iam",
}
no_policy_resource = generate_gcp_asset(
"key-management",
"gcp-iam",
{},
null, # missing resource.iam_policy
)