Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Docs migration] Cleans up getting started files - Pt. 1 #497

Merged
merged 29 commits into from
Feb 27, 2025
Merged

[Docs migration] Cleans up getting started files - Pt. 1 #497

merged 29 commits into from
Feb 27, 2025

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Feb 19, 2025 •
edited
Loading

Addresses part of #559 by doing the following:

  • Removes raw migrated Serverless files (content and some images) that are no longer being used.
  • Adds anchors where missing and updates anchors that start with an underscore.
  • Makes minor inline adjustments to the files that were labeled as "lift-and-shift" where appropriate.

Affected pages:

@nastasha-solomon nastasha-solomon added the documentation Improvements or additions to documentation label Feb 19, 2025
@nastasha-solomon nastasha-solomon self-assigned this Feb 19, 2025
@nastasha-solomon nastasha-solomon marked this pull request as ready for review February 21, 2025 03:35
@nastasha-solomon nastasha-solomon requested a review from a team February 21, 2025 03:35
@nastasha-solomon nastasha-solomon removed the request for review from a team February 21, 2025 14:34
@nastasha-solomon nastasha-solomon marked this pull request as draft February 21, 2025 14:34
@nastasha-solomon nastasha-solomon changed the title Cleans up getting started files [Docs migration] Cleans up getting started files Feb 21, 2025
@nastasha-solomon nastasha-solomon marked this pull request as ready for review February 21, 2025 20:24
@nastasha-solomon nastasha-solomon mentioned this pull request Feb 25, 2025
Open
3 tasks
benironside
benironside reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found a couple tiny things. Otherwise LGTM. Also wanted to comment that the pages listed in the PR description don't seem to quite align with the files changed in the diff. Hopefully none of your work got lost!

nastasha-solomon and others added 3 commits February 27, 2025 09:18
@nastasha-solomon @benironside
Update solutions/security/get-started/ingest-data-to-elastic-security.md
d7a5529 
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@nastasha-solomon @benironside
Update solutions/security/get-started/data-views-elastic-security.md
fac5489 
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@nastasha-solomon
Merge branch 'main' into rip-serverless-files-pt1
12e6aeb
@nastasha-solomon
Copy link
Contributor Author

Also wanted to comment that the pages listed in the PR description don't seem to quite align with the files changed in the diff. Hopefully none of your work got lost!

Thanks for the reminder here. The PR's scope changed quite a bit since I initially created it and I forgot to update the PR description. It's fixed now!

@nastasha-solomon nastasha-solomon changed the title [Docs migration] Cleans up getting started files [Docs migration] Cleans up getting started files - Pt. 1 Feb 27, 2025
@nastasha-solomon nastasha-solomon mentioned this pull request Feb 27, 2025
Open
@nastasha-solomon nastasha-solomon merged commit d1ee106 into main Feb 27, 2025
5 checks passed
@nastasha-solomon nastasha-solomon deleted the rip-serverless-files-pt1 branch February 27, 2025 17:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benironside benironside benironside approved these changes

Assignees

@nastasha-solomon nastasha-solomon

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nastasha-solomon @benironside