Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Manage your license page #539

Merged
merged 19 commits into from
Feb 26, 2025
Merged

Add Manage your license page #539

merged 19 commits into from
Feb 26, 2025

Conversation

marciw
Copy link
Contributor

@marciw marciw commented Feb 20, 2025 •
edited
Loading

Preview

  • Add basic landing page w/ links and resources
  • Add nav titles and other essentials for individual pages
  • Adjust order in TOC to match Deploy & manage > Deploy

Closes https://github.com/elastic/docs-projects/issues/303

@marciw marciw changed the title [WIP] Add landing page for Manage your license Add landing page for Manage your license Feb 20, 2025
@marciw marciw marked this pull request as ready for review February 20, 2025 17:21
@marciw marciw requested a review from shainaraskas February 20, 2025 17:21
marciw
marciw commented Feb 20, 2025
View reviewed changes
@marciw marciw changed the title Add landing page for Manage your license Add Manage your license page Feb 20, 2025
shainaraskas
shainaraskas reviewed Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🙏 🙏 🙏 ty for shaping this up!

left some comments around scope and some info about apis that can be applied ... sry for the lack of suggestions around the API notes

@marciw
Copy link
Contributor Author

marciw commented Feb 25, 2025

@shainaraskas attempted some improvements for when you have time / willingness to overlook corner-cutting

@marciw marciw requested a review from shainaraskas February 25, 2025 18:45
shainaraskas
shainaraskas reviewed Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some smol things left (applies_to error and a small clarification), otherwise good to go

marciw and others added 4 commits February 25, 2025 17:23
@marciw @shainaraskas
Apply suggestions from review
d4c73be 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@marciw @shainaraskas
Apply suggestions from review
eeb9553 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@marciw
Merge branch 'main' into mw-dm-license
13df32f
@marciw
remap
3f31193
@marciw marciw requested a review from shainaraskas February 25, 2025 22:43
shainaraskas
shainaraskas approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

shainaraskas
shainaraskas approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice I approved it twice

@marciw marciw merged commit 9a3ec20 into main Feb 26, 2025
4 checks passed
@marciw marciw deleted the mw-dm-license branch February 26, 2025 13:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shainaraskas shainaraskas shainaraskas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marciw @shainaraskas