-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[AWS Firehose] Improve firehose integration documents #578
Merged
Kavindu-Dodan
merged 4 commits into
elastic:main
from
Kavindu-Dodan:chore/update-firehose-documentation
Feb 28, 2025
Merged
[AWS Firehose] Improve firehose integration documents #578
Kavindu-Dodan
merged 4 commits into
elastic:main
from
Kavindu-Dodan:chore/update-firehose-documentation
Feb 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
39ccc46
to
975f3d3
Compare
alaudazzi
previously approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few minor editing suggestions. Otherwise LGTM.
solutions/observability/cloud/monitor-amazon-web-services-aws-with-amazon-data-firehose.md
Outdated
Show resolved
Hide resolved
solutions/observability/cloud/monitor-amazon-web-services-aws-with-amazon-data-firehose.md
Outdated
Show resolved
Hide resolved
solutions/observability/cloud/monitor-amazon-web-services-aws-with-amazon-data-firehose.md
Outdated
Show resolved
Hide resolved
84c432d
to
dfb9d0f
Compare
alaudazzi
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # solutions/observability/cloud/monitor-amazon-web-services-aws-with-amazon-data-firehose.md
…with-amazon-data-firehose.md Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
…with-amazon-data-firehose.md Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
…with-amazon-data-firehose.md Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
dfb9d0f
to
52c9c02
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves AWS Firehose documentation, aligning with the update done on AWS Firehose Integration documentation at elastic/integrations#12732
This is a follow-up of elastic/observability-docs#4818 for the new doc content repository.
Related issue
Related PR - elastic/observability-docs#4818
Related : elastic/integrations#12150
Related : elastic/observability-docs#4784