Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[AWS Firehose] Improve firehose integration documents #578

Merged

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Feb 24, 2025

Description

Improves AWS Firehose documentation, aligning with the update done on AWS Firehose Integration documentation at elastic/integrations#12732

This is a follow-up of elastic/observability-docs#4818 for the new doc content repository.

Related issue

Related PR - elastic/observability-docs#4818
Related : elastic/integrations#12150
Related : elastic/observability-docs#4784

@Kavindu-Dodan Kavindu-Dodan requested a review from a team February 24, 2025 17:27
@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/update-firehose-documentation branch 3 times, most recently from 39ccc46 to 975f3d3 Compare February 26, 2025 23:15
alaudazzi
alaudazzi previously approved these changes Feb 27, 2025
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few minor editing suggestions. Otherwise LGTM.

Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kavindu-Dodan and others added 4 commits February 28, 2025 06:48
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

# Conflicts:
#	solutions/observability/cloud/monitor-amazon-web-services-aws-with-amazon-data-firehose.md
…with-amazon-data-firehose.md

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
…with-amazon-data-firehose.md

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
…with-amazon-data-firehose.md

Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/update-firehose-documentation branch from dfb9d0f to 52c9c02 Compare February 28, 2025 14:48
@Kavindu-Dodan Kavindu-Dodan merged commit 62af413 into elastic:main Feb 28, 2025
4 checks passed
@Kavindu-Dodan Kavindu-Dodan deleted the chore/update-firehose-documentation branch February 28, 2025 14:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants