Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Align input options for --include and --subset arguments #899

Closed
ebeahan opened this issue Jul 27, 2020 · 4 comments
Closed

Align input options for --include and --subset arguments #899

ebeahan opened this issue Jul 27, 2020 · 4 comments
Assignees
@djptek
Labels
enhancement New feature or request ready Issues we'd like to address in the future.

Comments

@ebeahan
Copy link
Member

ebeahan commented Jul 27, 2020

Summary

There is inconsistency between the expected inputs for the --include and --subset arguments:

--include: Expects a single directory containing the YAML schema files
--subset: Expects a single subset definition YAML file. Will accept a directory but execution fails with an exception.

Proposal

The documentation (#893) has been improved to clarify, but the difference does cause confusions for users (#843). Propose adjusting each feature to accept both individual files or directories as valid inputs.
@ebeahan ebeahan added the enhancement New feature or request label Jul 27, 2020
@ebeahan ebeahan changed the title Improve --include and --subset file and directory handling Align input options for --include and --subset arguments Jul 27, 2020
@ebeahan ebeahan mentioned this issue Jul 27, 2020
Closed
@ebeahan ebeahan added the ready Issues we'd like to address in the future. label Aug 4, 2020
@webmat webmat added the 1.8.0 label Nov 17, 2020
@ebeahan ebeahan removed the 1.8.0 label Dec 15, 2020
@djptek
Copy link
Contributor

djptek commented Jul 12, 2021

@ebeahan can I take this one?

@ebeahan
Copy link
Member Author

ebeahan commented Jul 12, 2021

@djptek Absolutely!

@djptek djptek mentioned this issue Jul 15, 2021
Merged
@djptek
Copy link
Contributor

djptek commented Oct 20, 2021

PR submitted #1519

@ebeahan
Copy link
Member Author

ebeahan commented Dec 20, 2021

Resolved via #1519

@ebeahan ebeahan closed this as completed Dec 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@djptek djptek

Labels
enhancement New feature or request ready Issues we'd like to address in the future.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@webmat @ebeahan @djptek