-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Align input options for --include and --subset arguments #1519
Conversation
In Draft as need to add tests |
low level tests passing, working with include, exclude, subset. next step add higher level tests |
CHANGELOG.next.md
Outdated
@@ -10,6 +10,8 @@ Thanks, you're awesome :-) --> | |||
|
|||
### Schema Changes | |||
|
|||
* Align input options for --include and --subset arguments #1519 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of a tooling addition than a schema change, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, thanks for spotting @kgeller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Dominic!
moving back to draft while I create additional tests for --subset |
Checked Unit tests and I think coverage is OK, updated documentation to reflect changes from point of view of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small observation, but otherwise LGTM!
Thanks for addressing, @djptek! It'll be nice to have this consistency.
Co-authored-by: Eric Beahan <ebeahan@gmail.com>
@djptek, with this change aligning the input behavior of these two arguments, can it be implemented independently from the @timestamp conversation happening in #1646? |
@ebeahan I think I need to fix the |
I believe that's already true in the current tooling and not something introduced by these changes? If this change is ready, we can introduce your improvements here and address #1646 later. |
@djptek should this one be backported to |
make test
? Ymake
and committed those changes? YAddresses #899