Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add wildcard type support to go code generator #1050

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Add wildcard type support to go code generator #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d199ae
add wildcard type support
ebeahan Oct 26, 2020
87251cf
also add version and constant_keyword
ebeahan Oct 27, 2020
41c00ed
changelog
ebeahan Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Thanks, you're awesome :-) -->
* Added the `path` key when type is `alias`, to support the [alias field type](https://www.elastic.co/guide/en/elasticsearch/reference/current/alias.html). #877
* Added support for `scaled_float`'s mandatory parameter `scaling_factor`. #1042
* Added ability for --oss flag to fall back `constant_keyword` to `keyword`. #1046
* Added support in the generated Go source go for `wildcard`, `version`, and `constant_keyword` data types. #1050

#### Improvements

Expand Down
2 changes: 1 addition & 1 deletion scripts/cmd/gocodegen/gocodegen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ func goDataType(fieldName, elasticsearchDataType string) string {
}

switch elasticsearchDataType {
case "keyword", "text", "ip", "geo_point":
case "keyword", "wildcard", "version", "constant_keyword", "text", "ip", "geo_point":
return "string"
case "long":
return "int64"
Expand Down