Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename url.host.name to url.hostname. #147

Merged
merged 1 commit into from
Oct 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ All notable changes to this project will be documented in this file based on the
* Remove `log.offset` and `log.line` as too specific for ECS. #131
* Remove top level objects `kubernetes` and `tls`. #132
* Remove `*.timezone.offset.sec` fields as too specific for ECS at the moment. #134
* Make the following fields keyword: device.vendor, file.path, file.target_path, http.response.body, network.name, organization.name, url.href, url.path, url.query, user_agent.original
* Make the following fields keyword: device.vendor, file.path, file.target_path, http.response.body, network.name, organization.name, url.href, url.path, url.query, user_agent.original
* Rename `url.host.name` to `url.hostname` to better align with industry convention.

### Bugfixes

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ URL fields provide a complete URL, with scheme, host, and path. The URL object c
|---|---|---|---|---|
| <a name="url.href"></a>url.href | Full url. The field is stored as keyword. | keyword | | `https://elastic.co:443/search?q=elasticsearch#top` |
| <a name="url.scheme"></a>url.scheme | Scheme of the request, such as "https".<br/>Note: The `:` is not part of the scheme. | keyword | | `https` |
| <a name="url.host.name"></a>url.host.name | Hostname of the request, such as "example.com".<br/>For correlation the this field can be copied into the `host.name` field. | keyword | | `elastic.co` |
| <a name="url.hostname"></a>url.hostname | Hostname of the request, such as "elastic.co".<br/>In some cases a URL may refer to an IP and/or port directly, without a domain name. In this case, the IP address would go to the `hostname` field. | keyword | | `elastic.co` |
| <a name="url.port"></a>url.port | Port of the request, such as 443. | integer | | `443` |
| <a name="url.path"></a>url.path | Path of the request, such as "/search". | keyword | | |
| <a name="url.query"></a>url.query | The query field describes the query string of the request, such as "q=elasticsearch".<br/>The `?` is excluded from the query string. If a URL contains no `?`, there is no query field. If there is a `?` but no query, the query field exists with an empty string. The `exists` query can be used to differentiate between the two cases. | keyword | | |
Expand Down
8 changes: 4 additions & 4 deletions fields.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1120,14 +1120,14 @@
Note: The `:` is not part of the scheme.
example: https

- name: host.name
- name: hostname
level: extended
type: keyword
description: >
Hostname of the request, such as "example.com".
Hostname of the request, such as "elastic.co".

For correlation the this field can be copied into the `host.name`
field.
In some cases a URL may refer to an IP and/or port directly, without a
domain name. In this case, the IP address would go to the `hostname` field.
example: elastic.co

- name: port
Expand Down
2 changes: 1 addition & 1 deletion schema.csv
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ source.mac,keyword,0,
source.port,long,0,
source.subdomain,keyword,0,
url.fragment,keyword,0,
url.host.name,keyword,0,elastic.co
url.hostname,keyword,0,elastic.co
url.href,keyword,0,https://elastic.co:443/search?q=elasticsearch#top
url.password,keyword,0,
url.path,keyword,0,
Expand Down
8 changes: 4 additions & 4 deletions schemas/url.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@
Note: The `:` is not part of the scheme.
example: https

- name: host.name
- name: hostname
level: extended
type: keyword
description: >
Hostname of the request, such as "example.com".
Hostname of the request, such as "elastic.co".

For correlation the this field can be copied into the `host.name`
field.
In some cases a URL may refer to an IP and/or port directly, without a
domain name. In this case, the IP address would go to the `hostname` field.
example: elastic.co

- name: port
Expand Down
10 changes: 3 additions & 7 deletions template.json
Original file line number Diff line number Diff line change
Expand Up @@ -594,13 +594,9 @@
"ignore_above": 1024,
"type": "keyword"
},
"host": {
"properties": {
"name": {
"ignore_above": 1024,
"type": "keyword"
}
}
"hostname": {
"ignore_above": 1024,
"type": "keyword"
},
"href": {
"ignore_above": 1024,
Expand Down