Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove ignore_above parameter when indexing is disabled on field #1483

Merged
merged 6 commits into from
Jun 29, 2021
Merged

Remove ignore_above parameter when indexing is disabled on field #1483

merged 6 commits into from
Jun 29, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Jun 28, 2021

Remove the default ignore_above: 1024 parameter applied to all keyword type fields when index: false is set on the field.

Closes #1481

@ebeahan ebeahan self-assigned this Jun 28, 2021
@ebeahan ebeahan requested review from andrewkroh and a team June 28, 2021 21:36
djptek
djptek approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djptek djptek mentioned this pull request Jun 29, 2021
Closed
@ebeahan
Copy link
Member Author

ebeahan commented Jun 29, 2021

@elasticmachine run elasticsearch-ci/docs

@ebeahan
Copy link
Member Author

ebeahan commented Jun 29, 2021

Merging without the ✅ from elasticsearch-ci/docs (CI challenges), but this change doesn't impact the docs at all.

@ebeahan ebeahan merged commit d976b1a into elastic:master Jun 29, 2021
@ebeahan ebeahan deleted the bug/remove-invalid-ignore_above-param branch June 29, 2021 20:59
ebeahan added a commit to ebeahan/ecs that referenced this pull request Jun 29, 2021
@ebeahan
Remove ignore_above parameter when indexing is disabled on field (e…
96fd70d 
…lastic#1483)

* remove ignore_above if indexing is disabled for a field

* update artifacts

* linting

* changelog

* update artifacts
@ebeahan ebeahan mentioned this pull request Jun 29, 2021
Merged
ebeahan added a commit that referenced this pull request Jun 29, 2021
@ebeahan
Remove ignore_above parameter when indexing is disabled on field (#…
c69dbbc 
…1483) (#1489)

* remove ignore_above if indexing is disabled for a field

* update artifacts

* linting

* changelog

* update artifacts
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@djptek djptek djptek approved these changes

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees

@ebeahan ebeahan

Labels
1.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ignore_above setting when not indexing field
2 participants
@ebeahan @djptek