Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Progressing service.environment RFC to stage 2 #1536

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Jul 27, 2021

@eyalkoren eyalkoren added the RFC label Jul 27, 2021
@eyalkoren eyalkoren requested a review from ebeahan July 27, 2021 05:50
@ebeahan
Copy link
Member

ebeahan commented Jul 27, 2021

Stage 2 Criteria

  • Opened pull request for this draft revising the existing proposal
  • Completed field definitions
  • Included a real-world example source document
  • Identifies scope of impact of changes to ingestion mechanisms (e.g. beats/logstash), usage mechanisms (e.g. Kibana applications, detections), and the ECS project (e.g. docs, tooling)
  • Subject matter experts weighed in on the technical utility of field definitions in the pull request

@ebeahan
Copy link
Member

ebeahan commented Jul 27, 2021

Thanks for moving this forward, @eyalkoren. Like we chatted about elsewhere, this proposal is in great shape for stage 2 already.

@cyrille-leclerc @exekias @sqren all helped contribute to the earlier stages of this doc. I would appreciate it if you'd share any feedback or concerns about moving this forward.

@exekias, are you still ok with being listed as the sponsor?

@cyrille-leclerc
Copy link
Contributor

I have no concern regarding service.environment being the ECS field to describe the environment on which an application is being deployed

@exekias
Copy link

exekias commented Jul 28, 2021

@exekias, are you still ok with being listed as the sponsor?

SGTM!

Supporting several environments for the same app deployed across different environments is an important use case, having a field to differentiate these is really useful.

@ebeahan ebeahan merged commit 245adf2 into master Jul 28, 2021
@ebeahan ebeahan deleted the service-environment-rfc-stage2 branch July 28, 2021 22:20
@ebeahan
Copy link
Member

ebeahan commented Jul 28, 2021

Stage 2 implementation PR: #1541

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants