Clarify event definition - add metrics #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikePaquette
changed the title
ruflin
reviewed
Nov 29, 2018
MikePaquette
force-pushed
the
event-mods
branch
from
ed3cd7e to
230b9ab
Compare
MikePaquette
force-pushed
the
event-mods
branch
from
e4c325e to
bf67335
Compare
MikePaquette
added a commit
to MikePaquette/ecs-1
that referenced
this pull request
Dec 4, 2018
* Clarify Event definition - add metrics * Update CHANGELOG.md * clarify event/log/metric relationship * tweak changelog.md * still further tweak changelog
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the definition of the event fields at the start of the event section. Also mention that metrics details are to be included in the event fields.