Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Device fields RFC stage 2 and schema change #2030

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

AlexanderWert
Copy link
Member

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

@AlexanderWert AlexanderWert requested a review from kgeller August 17, 2022 06:25
@AlexanderWert AlexanderWert requested a review from a team as a code owner August 17, 2022 06:25
@kgeller
Copy link
Contributor

kgeller commented Aug 17, 2022

@AlexanderWert looks great, could you add a changelog entry?

@AlexanderWert
Copy link
Member Author

@kgeller Thanks! Added the changelog entry.

Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgeller kgeller added the 8.6.0 label Aug 17, 2022
@AlexanderWert AlexanderWert merged commit 474ba6d into elastic:main Aug 18, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants