Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding library category to the schema #2154

Merged
merged 11 commits into from
Feb 8, 2023
Merged

Adding library category to the schema #2154

merged 11 commits into from
Feb 8, 2023

Conversation

softengchick
Copy link
Contributor

Adds the currently used by Endpoint category value of "library".

  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?

@softengchick softengchick requested a review from a team as a code owner January 27, 2023 20:31
kgeller
kgeller approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tweaked the changelog to put your entry under 8.7 since you added that label to the PR. If that's a mistake, feel free to put it back and add the 8.8 label

@marc-gr marc-gr merged commit d6c7c79 into main Feb 8, 2023
@marc-gr marc-gr deleted the michelle/add-library-event-category branch February 8, 2023 11:17
marc-gr added a commit to marc-gr/ecs that referenced this pull request Feb 8, 2023
@softengchick @jrmolin
@kgeller @marc-gr
Adding library category to the schema (elastic#2154)
c58eaa7 
* Adding library category to the schema

* Change log

* revert accidental commit

* Correct gitignore

* ignore from main to correct line endings, etc

* make / make test / git add / commit / push

* Update CHANGELOG.next.md

---------

Co-authored-by: mo <jonathan.molinatto@elastic.co>
Co-authored-by: Kylie Geller <kylie.geller@elastic.co>
Co-authored-by: Marc Guasch <marc-gr@users.noreply.github.com>
@marc-gr marc-gr mentioned this pull request Feb 8, 2023
Merged
marc-gr added a commit that referenced this pull request Feb 8, 2023
@marc-gr @softengchick
@jrmolin @kgeller
Adding library category to the schema (#2154) (#2166)
1a54436 
* Adding library category to the schema

* Change log

* revert accidental commit

* Correct gitignore

* ignore from main to correct line endings, etc

* make / make test / git add / commit / push

* Update CHANGELOG.next.md

---------

Co-authored-by: Michelle Bennett <39916526+softengchick@users.noreply.github.com>
Co-authored-by: mo <jonathan.molinatto@elastic.co>
Co-authored-by: Kylie Geller <kylie.geller@elastic.co>
@andrewkroh andrewkroh mentioned this pull request Apr 3, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kgeller kgeller kgeller approved these changes

@gabriellandau gabriellandau gabriellandau approved these changes

Assignees
No one assigned
Labels
8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@softengchick @kgeller @gabriellandau @marc-gr @jrmolin