Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

container.security context.privileged boolean #2246

Merged
merged 3 commits into from
Aug 10, 2023
Merged

container.security context.privileged boolean #2246

merged 3 commits into from
Aug 10, 2023

Conversation

Tacklebox
Copy link
Contributor

My previous PR had the wrong type name.

bool -> boolean

@Tacklebox Tacklebox requested a review from a team as a code owner August 1, 2023 21:24
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Documentation changes preview: https://ecs_2246.docs-preview.app.elstc.co/diff

@Tacklebox Tacklebox force-pushed the mborden/container.security_context.privileged-boolean branch from 193aeba to e97f906 Compare August 1, 2023 21:27
kgeller
kgeller reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@kgeller kgeller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tacklebox thanks for fixing this!

Would you just add this PR to the changelog ie

* Added `container.privileged` to indicated whether a container was started in privileged mode. #2219, #2246

@eyalkoren eyalkoren mentioned this pull request Aug 3, 2023
Merged
3 tasks
ruflin
ruflin approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebeahan Do you know if we have any CI checks that could prevent this from happening as this is not a valid type in the first place?

@eyalkoren
Copy link
Contributor

@ebeahan Do you know if we have any CI checks that could prevent this from happening as this is not a valid type in the first place?

@ruflin Elasticsearch's CI will now tell us if such slips in 😉

ebeahan
ebeahan approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we also reference this fix in the CHANGELOG.next entry?

@ebeahan
Copy link
Member

ebeahan commented Aug 4, 2023

Do you know if we have any CI checks that could prevent this from happening as this is not a valid type in the first place?

AFAIK, surprisingly not. Filed an issue: #2249

@eyalkoren
Copy link
Contributor

Anything blocking this from being merged?

@kgeller
Copy link
Contributor

kgeller commented Aug 9, 2023

Anything blocking this from being merged?

@eyalkoren I assumed it was waiting on an outstanding review from @norrietaylor , but will merge if you all are ready

@Tacklebox Tacklebox merged commit a51f3ba into main Aug 10, 2023
@kgeller kgeller deleted the mborden/container.security_context.privileged-boolean branch August 10, 2023 20:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@ebeahan ebeahan ebeahan approved these changes

@kgeller kgeller kgeller approved these changes

@norrietaylor norrietaylor Awaiting requested review from norrietaylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tacklebox @eyalkoren @ebeahan @kgeller @ruflin