Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Stage 2 beta changes for RFC 0040, volume.* #2269

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Sep 11, 2023

Implement the changes proposed in RFC 0040 which has advanced to stage 2 (#2260).

These changes add a new volume.* field set to describe storage volume devices. The field set will be marked as beta since the RFC is currently at RFC stage 2.

@ebeahan ebeahan self-assigned this Sep 11, 2023
@ebeahan ebeahan requested a review from a team as a code owner September 11, 2023 20:26
@github-actions
Copy link

Documentation changes preview: https://ecs_2269.docs-preview.app.elstc.co/diff

@ebeahan ebeahan requested a review from Trinity2019 September 11, 2023 20:33
@ebeahan
Copy link
Member Author

ebeahan commented Sep 22, 2023

@Trinity2019 will you take a look? This PR is required to land the volume.* changes into the schema and publish into the ECS docs.

@ebeahan ebeahan force-pushed the rfc/0004/apply-stage-2-changes branch from 8525b33 to dfcac64 Compare October 2, 2023 17:09
Copy link
Contributor

@Trinity2019 Trinity2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ebeahan for moving the proposal into beta stage!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants