Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update template example in usage doc #2412

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Dec 6, 2024

The example for template.json in the usage doc for the custom template and mapping setting section was incorrect and did not work for both template types. This fixes the example to work with both.


  • Have you signed the contributor license agreement? y
  • Have you followed the contributor guidelines? y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? n/a
  • If submitting code/script changes, have you verified all tests pass locally using make test? n/a
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? n/a
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. y
  • Have you added an entry to the CHANGELOG.next.md? n/a

Closes #2342

The given example for template.json in the usage doc for custom template and mapping setting
section was incorrect, and did not work for both template types. This fixes the example to
work with both.
@mjwolf mjwolf merged commit a735abd into elastic:main Dec 7, 2024
3 checks passed
@mjwolf mjwolf deleted the tooling-template-docs branch December 7, 2024 00:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECS Tooling - Mapping & Template Settings
2 participants