Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix link rendering issues and usage of http in links #2423

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Fix link rendering issues and usage of http in links #2423

merged 5 commits into from
Jan 17, 2025

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jan 15, 2025 •
edited
Loading

Description

  • Removed link text markup, causes issues since final rendering of docs can be in either markdown or asciidoc
  • Replace http with https in links

Related Issues

@taylor-swanson
Fix link rendering issues and usage of http in links
8f92731 
- Removed link text markup
- Replace http with https in links
@taylor-swanson taylor-swanson self-assigned this Jan 15, 2025
@taylor-swanson taylor-swanson requested a review from a team as a code owner January 15, 2025 16:28
@github-actions GitHub Actions
Copy link

Documentation changes preview: https://ecs_bk_2423.docs-preview.app.elstc.co/diff

mjwolf
mjwolf approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@mjwolf mjwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I checked that there are no other markdown or asciidoc formatted links in the schema files too

@taylor-swanson taylor-swanson merged commit 66bd6dd into elastic:main Jan 17, 2025
2 checks passed
@taylor-swanson taylor-swanson deleted the fix/links branch January 17, 2025 15:05
@taylor-swanson taylor-swanson mentioned this pull request Jan 17, 2025
Closed
mjwolf pushed a commit to mjwolf/ecs that referenced this pull request Jan 17, 2025
@taylor-swanson @mjwolf
[Backport 8.x] Fix link rendering issues and usage of http in links (e…
1911f56 
…lastic#2423)

- Removed link text markup, causes issues since final rendering of docs can be in either markdown or asciidoc
- Replace http with https in links
mjwolf added a commit that referenced this pull request Jan 21, 2025
@mjwolf @taylor-swanson
[Backport 8.x] Fix link rendering issues and usage of http in links (#…
8552cce 
…2423) (#2426)

- Removed link text markup, causes issues since final rendering of docs can be in either markdown or asciidoc
- Replace http with https in links

Co-authored-by: Taylor Swanson <90622908+taylor-swanson@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mjwolf mjwolf mjwolf approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
backport-8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taylor-swanson @mjwolf