Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clarify geo field set description. #333

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Feb 18, 2019

Make it clearer that it's not necessarily based on GeoIP.

Copy link
Contributor

@MikePaquette MikePaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmat webmat merged commit 405676b into elastic:master Feb 22, 2019
@webmat webmat deleted the geo-not-ip branch February 22, 2019 20:56
webmat added a commit to webmat/ecs that referenced this pull request Mar 5, 2019
…astic#333)

Backport of PR elastic#333 to 1.0 branch. Original message:

Loosened up the definition of `geo` fieldset. Not necessarily geo-ip based.
webmat added a commit to webmat/ecs that referenced this pull request Mar 5, 2019
…astic#333)

Backport of PR elastic#333 to 1.0 branch. Original message:

Loosened up the definition of `geo` fieldset. Not necessarily geo-ip based.
webmat added a commit that referenced this pull request Mar 5, 2019
Backport of PR #333 to 1.0 branch. Original message:

Loosened up the definition of `geo` fieldset. Not necessarily geo-ip based.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants