Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[9.0](backport #7011) fix: set gateway k8s replicas spec #7021

Open
wants to merge 1 commit into
base: 9.0
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 25, 2025

What does this PR do?

If the spec.replicas field is not set for the gateway OpenTelemetry Collector, the horizontal Pod autoscaler fails with the following error:

Conditions:
  Type         Status  Reason          Message
  ----         ------  ------          -------
  AbleToScale  False   FailedGetScale  the HPA controller was unable to get the target's current scale: Internal error occurred: the spec replicas field ".spec.replicas" does not exist
Events:
  Type     Reason          Age                     From                       Message
  ----     ------          ----                    ----                       -------
  Warning  FailedGetScale  107s (x779 over 3h14m)  horizontal-pod-autoscaler  Internal error occurred: the spec replicas field ".spec.replicas" does not exist

The configuration will still deploy a gateway collector pod but not the minimum required neither won't be able to scale the pods accordingly.

Why is it important?

Fixes the deployment of the k8s Otel operator.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #7011 done by [Mergify](https://mergify.com).

* fix: set gateway k8s replicas spec

* chore: add fragments

(cherry picked from commit c356857)

# Conflicts:
#	deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml
#	testing/integration/otel_helm_test.go
@mergify mergify bot requested a review from a team as a code owner February 25, 2025 17:33
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Feb 25, 2025
@mergify mergify bot requested review from kaanyalti and andrzej-stencel and removed request for a team February 25, 2025 17:33
Copy link
Contributor Author

mergify bot commented Feb 25, 2025

Cherry-pick of c356857 has failed:

On branch mergify/bp/9.0/pr-7011
Your branch is up to date with 'origin/9.0'.

You are currently cherry-picking commit c3568571f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   changelog/fragments/1740492672-set-replicas-for-gateway-collector.yaml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml
	both modified:   testing/integration/otel_helm_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 25, 2025

💔 Build Failed

Failed CI Steps

History

cc @rogercoll

Copy link

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants