[9.0] Remove filebeatreceiver and metricbeat receiver to remove dependency on Beats #7023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmacknz
added
Team:Elastic-Agent-Control-Plane
cmacknz
requested review from
michel-laterman and
swiatekm
and removed request for
a team
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
1 task
|
💔 Build Failed
Failed CI Stepscc @cmacknz |
Closed
6 tasks
mauri870
approved these changes
Feb 26, 2025
pkoutsovasilis
approved these changes
Feb 26, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the filebeatreceiver and metricbeatreceiver and associated tests from the 9.0 branch.
Why is it important?
We need to update our dependency on otel-collector-contrib to get fixes to the elasticsearchexporter that the EDOT collector needs to go GA in 9.0. This update cannot be done because the otel dependency versions in Beats conflicts with the one we need. We can't update the otel dependency versions in Beats without upgraded Beats' dependency on the Prometheus packages, which introduce breaking changes we need time to adapt to. For full details see elastic/beats#42748.
There is no fast fix to this on the Beats side, this is IMO the least bad option. The other quick alternative would be to have Elastic Agent's 9.0 branch point to a feature branch in Beats with the dependency update (so 9.0 here would not point to 9.0 in Beats). That is less disruptive in this repository, but creates another unofficial branch to maintain as long as this situation goes on, and does not prevent this problem happening again with another dependency later that would require more work in the unofficial Beats branch. If it turns out this was the wrong decision, we can switch to the other approach at any time in the future by reverting this commit.
The intent is we'll revert this and bring the beat receiver components back once Beats can safely be updated to the appropriate OTel dependencies.
Disruptive User Impact
None, beats receivers are experimental and unannounced. This change isolates any impact to functionality that isn't meant to be usable externally in 9.0.
Related / blocked issues