Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ipv6): support ipv6 address in grpc config #7035

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kruskall
Copy link
Member

What does this PR do?

joining addr port using string concat only works with ipv4

stdlib has funcs in the net pkg to properly support ipv6

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

joining addr port using string concat only works with ipv4

stdlib has funcs in the net pkg to properly support ipv6
@kruskall kruskall added the bug Something isn't working label Feb 26, 2025
@kruskall kruskall requested a review from a team as a code owner February 26, 2025 03:07
Copy link
Contributor

mergify bot commented Feb 26, 2025

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

I will wait for tests to pass before giving approval.

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 26, 2025

💔 Build Failed

Failed CI Steps

History

cc @kruskall

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants