Skip to content

Added point in time support and the Search.iterate() method #1833

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2024
Merged

Added point in time support and the Search.iterate() method #1833

merged 3 commits into from
May 30, 2024

Conversation

miguelgrinberg
Copy link
Collaborator

@miguelgrinberg miguelgrinberg commented May 23, 2024 •
edited
Loading

This change adds two new methods to the Search class. The point_in_time() method and iterate(), to combine point_in_time() with search_after() to provide a better option to scan().

@miguelgrinberg miguelgrinberg force-pushed the pit-and-iterate branch 2 times, most recently from 92e5195 to 650ad7d Compare May 23, 2024 18:32
@miguelgrinberg miguelgrinberg marked this pull request as ready for review May 23, 2024 19:07
@miguelgrinberg miguelgrinberg requested a review from pquentin May 23, 2024 19:09
pquentin
pquentin approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

miguelgrinberg and others added 2 commits May 29, 2024 15:01
@miguelgrinberg @pquentin
Update elasticsearch_dsl/_async/search.py
d020c75 
Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
@miguelgrinberg
feedback
8fe1c8d
@miguelgrinberg miguelgrinberg merged commit 4a9d882 into elastic:main May 30, 2024
16 checks passed
@miguelgrinberg miguelgrinberg deleted the pit-and-iterate branch May 30, 2024 17:51
@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label May 30, 2024
github-actions bot pushed a commit that referenced this pull request May 30, 2024
@miguelgrinberg @pquentin @github-actions
Added point in time support and the Search.iterate() method (#1833)
7f36b6e 
* Added point in time support and the Search.iterate() method

* Update elasticsearch_dsl/_async/search.py

Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>

* feedback

---------

Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
(cherry picked from commit 4a9d882)
@github-actions github-actions bot mentioned this pull request May 30, 2024
Merged
miguelgrinberg added a commit that referenced this pull request May 30, 2024
@github-actions @miguelgrinberg
Added point in time support and the Search.iterate() method (#1833) (#…
aa02fe4 
…1834)

* Added point in time support and the Search.iterate() method

* Update elasticsearch_dsl/_async/search.py

Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>

* feedback

---------

Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
(cherry picked from commit 4a9d882)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
backport 8.x Backport to 8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelgrinberg @pquentin