Skip to content

Move default value of 'expand__to_dot' to a variable (#499) #809

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Move default value of 'expand__to_dot' to a variable (#499) #809

merged 1 commit into from
Jan 23, 2018

Conversation

TheName
Copy link
Contributor

@TheName TheName commented Jan 6, 2018

Can we please add it to branch 2.x as well?

@TheName
Copy link
Contributor Author

TheName commented Jan 10, 2018 via email

@0bsearch
Copy link
Contributor

0bsearch commented Jan 10, 2018 via email

@TheName
Copy link
Contributor Author

TheName commented Jan 16, 2018

@3lnc could you merge it then? :)

@0bsearch
Copy link
Contributor

Nope, I have no such permissions on this repo, we need to wait for @honzakral

@TheName
Copy link
Contributor Author

TheName commented Jan 21, 2018

@honzakral could you merge this PR, please?

@honzakral honzakral merged commit f64b317 into elastic:2.x Jan 23, 2018
@honzakral
Copy link
Contributor

@TheName merged, hope it helps!

@TheName
Copy link
Contributor Author

TheName commented Jan 30, 2018

@honzakral thank you! :)

@TheName
Copy link
Contributor Author

TheName commented Feb 1, 2018

@honzakral one more question: Is pypi package v2 going to be updated to the newest code version sometime soon? I was hoping so, that's why it was important for me to merge this code change :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants