Update helpers to use new multisearch types #2697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JoshMock
commented
Apr 4, 2025
JoshMock
commented
- Update helpers to use correct multisearch types
- Stop copying project files to Dockerfile
The spec combined definitions for search and multisearch bodies in elastic/elasticsearch-specification#2960.
Slightly faster run times for codegen, hopefully.
|
CI failures are a chicken-and-egg problem that will be fixed on the next successful code generation, which is currently failing without the fix this PR makes. Will immediately rerun codegen after merging this. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
* Update helpers to use correct multisearch types The spec combined definitions for search and multisearch bodies in elastic/elasticsearch-specification#2960. * Stop copying project files to Dockerfile Slightly faster run times for codegen, hopefully. (cherry picked from commit b2a4907)
JoshMock
added a commit
that referenced
this pull request
Apr 4, 2025
* Update helpers to use correct multisearch types The spec combined definitions for search and multisearch bodies in elastic/elasticsearch-specification#2960. * Stop copying project files to Dockerfile Slightly faster run times for codegen, hopefully. (cherry picked from commit b2a4907) Co-authored-by: Josh Mock <joshua.mock@elastic.co>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.