bug fix #269
Merged
bug fix #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit of Fetch Surrounding Chunks python notebook
added !pip install pandas
fixed issue during checks. installed google.colab
updated notebook to use api key instead of username and password similar to notebook here: https://colab.research.google.com/github/elastic/elasticsearch-labs/blob/main/notebooks/search/00-quick-start.ipynb#scrollTo=f38e0397
Updated notebook to handle downloading required models such as elser and sentence transformer minilm
var chapter_number was not initialized. Fixed.
bug chapter_number = None. forgot = sign
added es_model_id
remove es_model_id as it is not needed.
dense_embedding_model_id was missing from query. renamed.
for debugging changed max_chapter_chunk_result
added error handling
added open in colab
|
Found 1 changed notebook. Review the changes at https://gitnotebooks.com/elastic/elasticsearch-labs/pull/269 |
joemcelroy
reviewed
Jun 10, 2024
| @@ -39,13 +39,13 @@ | |||
| }, | |||
There was a problem hiding this comment.
Commented on notebook supporting-blog-content/fetch-surrounding-chunks/fetch-surrounding-chunks.ipynb Cell 5 Line 32
# Create the client instance
esclient = Elasticsearch(
cloud_id=ELASTIC_CLOUD_ID,
api_key=ELASTIC_API_KEY,
)
print(esclient.info())contains UserWarning. suggest not commit this.
Respond and view the context here.
There was a problem hiding this comment.
@joemcelroy thank you. Issue resolved and pushed. review requested.
joemcelroy
approved these changes
Jun 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During @consulthys review of the nookbook, he found dup chunks were being printed out. fixed.