Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added tags aggregation in SearchController for .NET Core example #29

Open
wants to merge 1 commit into
base: 6.x-codecomplete-netcore
Choose a base branch
from

Conversation

rdcm
Copy link

@rdcm rdcm commented Jul 27, 2018

No description provided.

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @rdcm!

Before this can be merged, the README walkthrough would also need to be updated to reflect the changes within the code, since the two are intended to be used together.

Is this something that you would be able to address?

@rdcm
Copy link
Author

rdcm commented Jul 31, 2018

@russcam i take this code from branch
https://github.com/elastic/elasticsearch-net-example/blob/5.x-codecomplete-netcore-modifications/src/NuSearch.Web/Modules/Search/Search/SearchController.cs

with little bit refactoring.

Readme in 5.x-codecomplete-netcore-modifications branch not reflect the real code in controller, not contains Apply.. methods and tags aggregations description. I'm not sure I can describe it well. But without this feature sample does not look complete.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants