Restore default metric='_all' to cluster.state() #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzakral
reviewed
Mar 10, 2020
elasticsearch/client/cluster.py
Outdated
| @@ -102,6 +102,9 @@ def state(self, metric=None, index=None, params=None): | |||
| :arg wait_for_timeout: The maximum time to wait for | |||
| wait_for_metadata_version before timing out | |||
| """ | |||
| if index and not metric: | |||
There was a problem hiding this comment.
I think just for consistency we might want to check against SKIP_IN_PATH instead of just the bool value. It amounts to the same thing in this case pretty much but would probably be better
…ticsearch-py into cluster-state-default
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this little piece of logic was lost in the API auto-generation commit. I went through that commit and I didn't see any other special logic that was lost so we should be good now?
Should probably release a 7.5.2 with the past few commits and fixes.
Closes #1141