Don't raise sniffing error when retrying request #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
force-pushed
the
fix-sniffing-fail-on-retry
branch
from
32b8279 to
6e0f7ad
Compare
|
Only failure is 3.7 on GHA for unrelated install reasons. Merging this. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an HTTP request fails and we decide to retry the request,
mark_dead()can cause a sniff attempt to start ifsniff_on_connection_fail=True. We don't want to interrupt a retry if a sniff request fails, instead we'd rather retry or raise the original exception that occurred.Related: #1279