Skip to content

Remove redundat np.float_ to fix numpy 2.X in 7.X elastic #2647

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

alvarogf97
Copy link

Resolves #2646 on 7.X

Copy link

cla-checker-service bot commented Aug 27, 2024

💚 CLA has been signed

@alvarogf97 alvarogf97 changed the title Remove redundat np.float_ to fix numpy 2.X Remove redundat np.float_ to fix numpy 2.X in 7.X elastic Aug 27, 2024
@pquentin
Copy link
Member

Thanks! The CI failures are expected. However, I can't merge this without the CLA, sorry. Make sure to use the same email as in your commit: https://github.com/elastic/elasticsearch-py/commit/b897656b1594fb68b09653291bf5e36794ad0425.patch

@alvarogf97
Copy link
Author

alvarogf97 commented Aug 28, 2024

Thanks! The CI failures are expected. However, I can't merge this without the CLA, sorry. Make sure to use the same email as in your commit: https://github.com/elastic/elasticsearch-py/commit/b897656b1594fb68b09653291bf5e36794ad0425.patch

I signed it twice and still does not work. I am currently using my github profile default email and username, should I do anything else?

btw I used another email in the commit, I'm fixing it

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin pquentin merged commit 83251d1 into elastic:7.17 Aug 28, 2024
10 of 12 checks passed
@pquentin
Copy link
Member

Thank you for your patience. https://github.com/elastic/elasticsearch-py/releases/tag/v7.17.12 is now out with this change.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants