Address Rails 7.1 deprecation warning in elasticsearch-rails #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR switches the elasticsearch-rails gem to use a new signature of the ActiveSupport::LogSubscriber#color method when called in an app using Rails 7.1+. With older Rails, the gem uses the working, old signature.
|
@picandocodigo do you plan to merge that MR into I see that you're working on a new version for this gem, do we have any kind if ETA for the release ? thx 😄 |
picandocodigo
approved these changes
May 14, 2024
|
hello Do you have any plan about this PR backport to |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches the elasticsearch-rails gem to use a new signature of the ActiveSupport::LogSubscriber#color
method when called in an app using Rails 7.1+.
With older Rails, the gem uses the working, old signature.
An example of a deprecation warning visible in 7.1 apps