Only execute update if document attributes is not empty #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonbwhite Thanks for this pull request. Would you mind adding a test for this scenario Thanks! |
|
@estolfo added the test! |
|
@jonbwhite The test failures were unrelated to your change, but just to be sure, would you mind rebasing against master so the tests can run in travis with the latest commit to master? Thanks! |
jonbwhite
force-pushed
the
prevent-empty-updates
branch
from
8e3d3ab
to
c28c4c5
Compare
|
@estolfo rebased and tests are passing now |
|
Thank you @jonbwhite ! |
estolfo
pushed a commit
that referenced
this pull request
Dec 17, 2018
* Only execute update if document attributes is not empty * Adds test for skipping empty elasticsearch update
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a model has an attribute changed, but that attribute is not part of the elasticsearch template, an empty update will be made to elasticsearch. This change only follows through on the update if there is content in the distilled attributes hash.