You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Ruby 3 changed the way keyword arguments work, Rails now only accepts keyword arguments for find_in_batches. Unfortunately, the method_missing implementation on Elasticsearch::Model::Proxy doesn't proxy keyword arguments, so Rails now explodes. The error is triggered by calling Model.import, and looks something like this:
ArgumentError: wrong number of arguments (given 1, expected 0)
bundle/gems/activerecord-6.1.3.1/lib/active_record/relation/batches.rb:128:in 'find_in_batches'
The fix is to forward not just positional arguments, but also keyword arguments. This PR adds a test (failing before the patch), and a patch to forward keyword arguments.
I've updated the implementation to work on Ruby 2.4 through 3.0, based on this ruby-core blog post, which should keep this change backwards-compatible.
momocus
added a commit
to momocus/sakazuki
that referenced
this pull request
Jul 3, 2021
Hi @indirect,
Thank you very much for this contribution! I'm working on a new release and I'd like to include this change. However, could you please restore this line? We need to keep the license header on every source code file.
when the proxy fails to forward keywoard arguments, the error for
methods that only accept keyword arguments looks like this:
ArgumentError:
wrong number of arguments (given 1, expected 0)
since Ruby 1.9.2, about 12 years ago, you're supposed to define respond_to_missing? if you also define method_missing. there's more explanation in this blog post by a ruby committer in 2010:
http://blog.marc-andre.ca/2010/11/15/methodmissing-politely/
Would it be possible to add this patch to the 6.x version? We are using Elasticsearch 6 and would love to have Ruby 3 support in 6.1.2 too. Right now we have to monkeypatch.
Would it be possible to add this patch to the 6.x version? We are using Elasticsearch 6 and would love to have Ruby 3 support in 6.1.2 too. Right now we have to monkeypatch.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indirect
force-pushed
the
proxy-argument-error-fix
branch
from
Since Ruby 3 changed the way keyword arguments work, Rails now only accepts keyword arguments for
find_in_batches. Unfortunately, themethod_missingimplementation onElasticsearch::Model::Proxydoesn't proxy keyword arguments, so Rails now explodes. The error is triggered by callingModel.import, and looks something like this:The fix is to forward not just positional arguments, but also keyword arguments. This PR adds a test (failing before the patch), and a patch to forward keyword arguments.
Fixes #989, #977.