Refactor IndicesRequestCache to make it testable. #16610
Merged
+934
−526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves IndicesRequestCache into o.e.indics and makes all API in this class package private. All references to SearchReqeust, SearchContext etc. have been factored out and relevant glue code has been added to IndicesService. The IndicesRequestCache is not a simple class without any hard dependencies on ThreadPool nor SearchService or IndexShard. This now allows to add unittests. This commit also removes two settings `indices.requests.cache.clean_interval` and `indices.fielddata.cache.clean_interval` in favor of `indices.cache.clean_interval` which cleans both caches.
|
@jpountz can you review that please |
|
The change looks good. I'm not too sure about the merge of the clean interval setting. I would rather remove this setting entirely given that it makes little sense since those caches cannot become stale. |
you mean just have it fixed to 1 min? |
|
Oh sorry, this setting does not do what I thought it did. I thought it would remove all entries from the cache. LGTM then. |
s1monw
added a commit
that referenced
this pull request
Feb 12, 2016
Refactor IndicesRequestCache to make it testable.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves IndicesRequestCache into o.e.indics and makes all API in this
class package private. All references to SearchReqeust, SearchContext etc. have been factored
out and relevant glue code has been added to IndicesService. The IndicesRequestCache is not a
simple class without any hard dependencies on ThreadPool nor SearchService or IndexShard. This now
allows to add unittests.
This commit also removes two settings
indices.requests.cache.clean_intervalandindices.fielddata.cache.clean_intervalin favor of
indices.cache.clean_intervalwhich cleans both caches.