Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace most context.TODO calls, comment on other Background and TODOs #4168

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented Dec 2, 2024

What is the problem this PR solves?

Replace use of context.TODO and context.Background from most use cases

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@michel-laterman michel-laterman added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team tech debt labels Dec 2, 2024
@michel-laterman michel-laterman requested a review from a team as a code owner December 2, 2024 18:28
Copy link
Contributor

mergify bot commented Dec 2, 2024

This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Dec 2, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 2, 2024
@michel-laterman michel-laterman mentioned this pull request Dec 2, 2024
2 tasks
@michel-laterman
Copy link
Contributor Author

Looks like there is a flaky test: #4170

Copy link
Contributor

mergify bot commented Dec 4, 2024

This pull request is now in conflicts. Could you fix it @michel-laterman? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b todo-log upstream/todo-log
git merge upstream/main
git push upstream todo-log

@michel-laterman michel-laterman enabled auto-merge (squash) December 5, 2024 17:51
@michel-laterman
Copy link
Contributor Author

Integration test is flaky, fix in #4171

@michel-laterman
Copy link
Contributor Author

buildkite test this

@michel-laterman michel-laterman merged commit cf41f38 into elastic:main Dec 5, 2024
8 checks passed
mergify bot pushed a commit that referenced this pull request Dec 5, 2024
#4168)

(cherry picked from commit cf41f38)

# Conflicts:
#	internal/pkg/config/config.go
#	internal/pkg/server/fleet.go
michel-laterman added a commit that referenced this pull request Dec 10, 2024
…er Background and TODOs (#4180)

* Replace most context.TODO calls, comment on other Background and TODOs (#4168)

(cherry picked from commit cf41f38)

# Conflicts:
#	internal/pkg/config/config.go
#	internal/pkg/server/fleet.go

* Fix merge conflict

* Fix linter

* fix deprecated options check

---------

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
Co-authored-by: michel-laterman <michel.laterman@elastic.co>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

context.TODO and loggers
2 participants