-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Replace most context.TODO calls, comment on other Background and TODOs #4168
Conversation
This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
|
|
Looks like there is a flaky test: #4170 |
b531d6f
to
7beddca
Compare
This pull request is now in conflicts. Could you fix it @michel-laterman? 🙏
|
Integration test is flaky, fix in #4171 |
buildkite test this |
|
…er Background and TODOs (#4180) * Replace most context.TODO calls, comment on other Background and TODOs (#4168) (cherry picked from commit cf41f38) # Conflicts: # internal/pkg/config/config.go # internal/pkg/server/fleet.go * Fix merge conflict * Fix linter * fix deprecated options check --------- Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>
What is the problem this PR solves?
Replace use of context.TODO and context.Background from most use cases
Design Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragments
using the changelog toolRelated issues