-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[kibana] - Add additionals labels #225
[kibana] - Add additionals labels #225
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
e3edaa1
to
fc62de0
Compare
Hello, i'm not sure if i need to do something on my side ? Thanks |
Hi @plumcraft, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@plumcraft The message from elasticcla describes what you need to do. Once you have added the email address you used in the commit just leave a new comment and it will re-run the cla check. jenkins test this please |
@Crazybus : thanks for your feedback, i've added my another email into my github profile, it should be fine now. |
fc62de0
to
e92e910
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jenkins test this please |
Co-Authored-By: Michael Russell <Crazybus@users.noreply.github.com>
jenkins test this please |
Thank you for adding this in! Extra bonus points for adding a test too :) |
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml