Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[helm-tester] migrate to python 3 #297

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Sep 20, 2019

Does what it says on the tin

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@jmlrt jmlrt requested a review from Crazybus September 20, 2019 12:11
@jmlrt
Copy link
Member Author

jmlrt commented Sep 20, 2019

I don't know if we should stay with -onbuild Python Docker images as they seem to be deprecated (see docker-library/official-images#2076).

But first test with python:3.7 image is failing. I need to dig deeper at differences between onbuild and standard Docker images.

@jmlrt
Copy link
Member Author

jmlrt commented Sep 20, 2019

jenkins test this please

@Crazybus Crazybus removed their request for review September 24, 2019 14:37
@jmlrt
Copy link
Member Author

jmlrt commented Sep 24, 2019

jenkins test this please

@jmlrt jmlrt force-pushed the python3-helm-tester branch from 6c1a6ad to 2a1b448 Compare September 25, 2019 08:55
docker onbuild have been deprecated in docker-library/official-images#2076 and aren't part of python docker images build since docker-library/python#314.
@jmlrt jmlrt force-pushed the python3-helm-tester branch from 2a1b448 to 8e3a887 Compare September 25, 2019 08:56
@jmlrt jmlrt requested a review from Crazybus September 25, 2019 09:41
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants