Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

FAQ and examples improvements (#598) #600

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Apr 28, 2020

  • Add missing section in contributing guide
  • Add note about ECK
  • Add more FAQ topics
  • Document all examples
  • NIT: fixes typos...

- Add missing section in contributing guide
- Add note about ECK
- Add more FAQ topics
- Document all examples
- NIT: fixes typos...
@jmlrt jmlrt added enhancement New feature or request v7.7.0 labels Apr 28, 2020
@jmlrt jmlrt requested a review from mgreau April 28, 2020 17:28
Copy link

@mgreau mgreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -150,15 +149,20 @@ about our development and testing process.
[CONTRIBUTING.md]: https://github.com/elastic/helm-charts/blob/master/CONTRIBUTING.md
[affinity]: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity
[annotations]: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
[apm server docker image]: https://www.elastic.co/guide/en/apm/server/current/running-on-docker.html
[apm server docker image]: https://www.elastic.co/guide/en/apm/server/7.7/running-on-docker.html
[apm server oss docker image]: https://www.docker.elastic.co/#apm-server-7-6-2-oss
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 7.7 I guess?

@jmlrt jmlrt merged commit f3f4e27 into elastic:7.7 Apr 28, 2020
@jmlrt jmlrt deleted the 77-doc-improvements-2 branch April 28, 2020 17:47
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
enhancement New feature or request v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants