Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Epic][Security Solution][Detection Engine] add request logging on preview for the rest of rule types #202545

Open
4 of 5 tasks
vitaliidm opened this issue Dec 2, 2024 · 2 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Detection Rule Preview Security Solution Detection Rule Preview feature Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team

Comments

@vitaliidm
Copy link
Contributor

vitaliidm commented Dec 2, 2024

PR #191107 has introduced logging of ES requests during preview for ES|QL and EQL rule types.

Extend this feature to the rest of rules:

  • IM
  • New terms
  • Query
  • ML
  • Threshold
@vitaliidm vitaliidm added Team:Detections and Resp Security Detection Response Team Team:Detection Engine Security Solution Detection Engine Area labels Dec 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@vitaliidm vitaliidm self-assigned this Dec 2, 2024
@yctercero yctercero added enhancement New value added to drive a business result Feature:Detection Rule Preview Security Solution Detection Rule Preview feature labels Jan 3, 2025
vitaliidm added a commit that referenced this issue Jan 28, 2025
…r new terms, threshold, query, ML rule types (#203320)

## Summary

- partially addresses #202545
(except of IM rule type)
- extends logged requests preview for:
  - [x] New terms
  - [x] Query
  - [x] ML
  - [x] Threshold
- For Threshold, Query, New terms rule type introduced Page view, where
each loop of rule execution is presented as a separate page
- Only first 2 search queries requests of each type are logged for
performance reasons(rule can have very a large and multiple requests).
That's why property **request** was made not mandatory in
`rule_preview.schema.yaml`


### DEMO



https://github.com/user-attachments/assets/abfbd3ff-d06c-4892-b805-0f05084042ed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 28, 2025
…r new terms, threshold, query, ML rule types (elastic#203320)

## Summary

- partially addresses elastic#202545
(except of IM rule type)
- extends logged requests preview for:
  - [x] New terms
  - [x] Query
  - [x] ML
  - [x] Threshold
- For Threshold, Query, New terms rule type introduced Page view, where
each loop of rule execution is presented as a separate page
- Only first 2 search queries requests of each type are logged for
performance reasons(rule can have very a large and multiple requests).
That's why property **request** was made not mandatory in
`rule_preview.schema.yaml`

### DEMO

https://github.com/user-attachments/assets/abfbd3ff-d06c-4892-b805-0f05084042ed

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0f996c3)
@yctercero yctercero changed the title [Security Solution][Detection Engine] add request logging on preview for the rest of rule types [Epic][Security Solution][Detection Engine] add request logging on preview for the rest of rule types Jan 28, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New value added to drive a business result Feature:Detection Rule Preview Security Solution Detection Rule Preview feature Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team
Projects
None yet
Development

No branches or pull requests

3 participants