Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix FSREQCALLBACK open handles in Jest tests #117984

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

jloleysens
Copy link
Contributor

Summary

Closes #115881

Per the title.

How to test

Run the following command locally:

node scripts/jest --config x-pack/plugins/reporting/jest.config.js --detectOpenHandles ./x-pack/plugins/reporting/server/browsers/download/ensure_downloaded.test.ts

Ensure that there are no warnings about open handles being reported.

Additional context

@cla-checker-service
Copy link

cla-checker-service bot commented Nov 9, 2021

💚 CLA has been signed

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jloleysens jloleysens merged commit 7ab3593 into elastic:main Nov 10, 2021
@jloleysens jloleysens deleted the upgrade-mock-fs branch November 10, 2021 10:43
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 10, 2021
* upgrade mock-fs

* elastic@ email address
jloleysens added a commit that referenced this pull request Nov 10, 2021
* upgrade mock-fs

* elastic@ email address
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
* upgrade mock-fs

* elastic@ email address
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
* upgrade mock-fs

* elastic@ email address
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reporting tests with open handles preventing Jest from completing
3 participants