[Streams] App plugin #200060
Merged
[Streams] App plugin #200060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into init-streams-plugin
1 task
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
Creates the Streams app plugin, which renders UI for managing streams (see elastic#198713). Additional changes in this PR: - The menus were updated to conditionally add a link to the Streams app. The Streams plugin itself returns a status$ observable which signals if Streams have been enabled. This value is used to conditionally render the link in the various flavors of menus. - There's a small change in the ES types to allow for ordered params in ES|QL (vs named params) - `@kbn/server-route-repository` was updated to be able to override `access` (instead of only inferring it from the endpoint name). Additionally, we now allow all route options by default. - `@kbn/typed-react-router-config` now also exports a `useBreadcrumbs`. This was copied over from the APM implementation. - the signature of the `esql` method in `ObservabilityElasticsearchClient` was updated to separate processing options from options that are sent over to the _query endpoint. --------- Co-authored-by: Chris Cowan <chris@elastic.co> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Nov 27, 2024
Creates the Streams app plugin, which renders UI for managing streams (see elastic#198713). Additional changes in this PR: - The menus were updated to conditionally add a link to the Streams app. The Streams plugin itself returns a status$ observable which signals if Streams have been enabled. This value is used to conditionally render the link in the various flavors of menus. - There's a small change in the ES types to allow for ordered params in ES|QL (vs named params) - `@kbn/server-route-repository` was updated to be able to override `access` (instead of only inferring it from the endpoint name). Additionally, we now allow all route options by default. - `@kbn/typed-react-router-config` now also exports a `useBreadcrumbs`. This was copied over from the APM implementation. - the signature of the `esql` method in `ObservabilityElasticsearchClient` was updated to separate processing options from options that are sent over to the _query endpoint. --------- Co-authored-by: Chris Cowan <chris@elastic.co> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 63da770) # Conflicts: # .github/CODEOWNERS
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
This was referenced Nov 27, 2024
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
This was referenced Nov 28, 2024
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
This was referenced Nov 29, 2024
cauemarcondes
added a commit
that referenced
this pull request
Dec 2, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Streams] App plugin (#200060)](#200060) <!--- Backport version: 7.3.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT {commits} BACKPORT--> --------- Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Creates the Streams app plugin, which renders UI for managing streams (see elastic#198713). Additional changes in this PR: - The menus were updated to conditionally add a link to the Streams app. The Streams plugin itself returns a status$ observable which signals if Streams have been enabled. This value is used to conditionally render the link in the various flavors of menus. - There's a small change in the ES types to allow for ordered params in ES|QL (vs named params) - `@kbn/server-route-repository` was updated to be able to override `access` (instead of only inferring it from the endpoint name). Additionally, we now allow all route options by default. - `@kbn/typed-react-router-config` now also exports a `useBreadcrumbs`. This was copied over from the APM implementation. - the signature of the `esql` method in `ObservabilityElasticsearchClient` was updated to separate processing options from options that are sent over to the _query endpoint. --------- Co-authored-by: Chris Cowan <chris@elastic.co> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Jan 7, 2025
jennypavlova
added a commit
that referenced
this pull request
Jan 7, 2025
Closes #203740 ## Summary This PR fixes failing test by changing read role permission to include `streams` and `apm`. As I mentioned in this [comment](#203740 (comment)) I saw some 403 errors related to some `streams` and `apm` APIs requests so this should fix the test as it was meant to test if the dashboards tab behaves correctly based on the admin/read-only role. However, we should think about a solution to those errors in case we have this scenario (read-only user role without apm/streams access) and have a better error message/explanation of what is missing instead of only showing the error toasts - I saw that we reverted (#202418) already a solution (#200151) for APM because of other issues but now that we also include the `streams` (#200060) (not sure if we need to do the request in infra but that's probably a different discussion) it's something we can revisit at one point to improve the user experience.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 7, 2025
…5707) Closes elastic#203740 ## Summary This PR fixes failing test by changing read role permission to include `streams` and `apm`. As I mentioned in this [comment](elastic#203740 (comment)) I saw some 403 errors related to some `streams` and `apm` APIs requests so this should fix the test as it was meant to test if the dashboards tab behaves correctly based on the admin/read-only role. However, we should think about a solution to those errors in case we have this scenario (read-only user role without apm/streams access) and have a better error message/explanation of what is missing instead of only showing the error toasts - I saw that we reverted (elastic#202418) already a solution (elastic#200151) for APM because of other issues but now that we also include the `streams` (elastic#200060) (not sure if we need to do the request in infra but that's probably a different discussion) it's something we can revisit at one point to improve the user experience. (cherry picked from commit 6fc90d0)
kibanamachine
added a commit
that referenced
this pull request
Jan 7, 2025
) (#205747) # Backport This will backport the following commits from `main` to `8.x`: - [[Infra] Fix failing test by changing read role permission (#205707)](#205707) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-01-07T14:10:04Z","message":"[Infra] Fix failing test by changing read role permission (#205707)\n\nCloses #203740\r\n## Summary\r\n\r\nThis PR fixes failing test by changing read role permission to include\r\n`streams` and `apm`. As I mentioned in this\r\n[comment](https://github.com/elastic/kibana/issues/203740#issuecomment-2574907832)\r\nI saw some 403 errors related to some `streams` and `apm` APIs requests\r\nso this should fix the test as it was meant to test if the dashboards\r\ntab behaves correctly based on the admin/read-only role.\r\n\r\nHowever, we should think about a solution to those errors in case we\r\nhave this scenario (read-only user role without apm/streams access) and\r\nhave a better error message/explanation of what is missing instead of\r\nonly showing the error toasts - I saw that we reverted\r\n(#202418) already a solution\r\n(#200151) for APM because of\r\nother issues but now that we also include the `streams`\r\n(#200060) (not sure if we need to\r\ndo the request in infra but that's probably a different discussion) it's\r\nsomething we can revisit at one point to improve the user experience.","sha":"6fc90d0410445cdb79419d0f6132a442d595a4e7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"title":"[Infra] Fix failing test by changing read role permission ","number":205707,"url":"https://github.com/elastic/kibana/pull/205707","mergeCommit":{"message":"[Infra] Fix failing test by changing read role permission (#205707)\n\nCloses #203740\r\n## Summary\r\n\r\nThis PR fixes failing test by changing read role permission to include\r\n`streams` and `apm`. As I mentioned in this\r\n[comment](https://github.com/elastic/kibana/issues/203740#issuecomment-2574907832)\r\nI saw some 403 errors related to some `streams` and `apm` APIs requests\r\nso this should fix the test as it was meant to test if the dashboards\r\ntab behaves correctly based on the admin/read-only role.\r\n\r\nHowever, we should think about a solution to those errors in case we\r\nhave this scenario (read-only user role without apm/streams access) and\r\nhave a better error message/explanation of what is missing instead of\r\nonly showing the error toasts - I saw that we reverted\r\n(#202418) already a solution\r\n(#200151) for APM because of\r\nother issues but now that we also include the `streams`\r\n(#200060) (not sure if we need to\r\ndo the request in infra but that's probably a different discussion) it's\r\nsomething we can revisit at one point to improve the user experience.","sha":"6fc90d0410445cdb79419d0f6132a442d595a4e7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205707","number":205707,"mergeCommit":{"message":"[Infra] Fix failing test by changing read role permission (#205707)\n\nCloses #203740\r\n## Summary\r\n\r\nThis PR fixes failing test by changing read role permission to include\r\n`streams` and `apm`. As I mentioned in this\r\n[comment](https://github.com/elastic/kibana/issues/203740#issuecomment-2574907832)\r\nI saw some 403 errors related to some `streams` and `apm` APIs requests\r\nso this should fix the test as it was meant to test if the dashboards\r\ntab behaves correctly based on the admin/read-only role.\r\n\r\nHowever, we should think about a solution to those errors in case we\r\nhave this scenario (read-only user role without apm/streams access) and\r\nhave a better error message/explanation of what is missing instead of\r\nonly showing the error toasts - I saw that we reverted\r\n(#202418) already a solution\r\n(#200151) for APM because of\r\nother issues but now that we also include the `streams`\r\n(#200060) (not sure if we need to\r\ndo the request in infra but that's probably a different discussion) it's\r\nsomething we can revisit at one point to improve the user experience.","sha":"6fc90d0410445cdb79419d0f6132a442d595a4e7"}}]}] BACKPORT--> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…5707) Closes elastic#203740 ## Summary This PR fixes failing test by changing read role permission to include `streams` and `apm`. As I mentioned in this [comment](elastic#203740 (comment)) I saw some 403 errors related to some `streams` and `apm` APIs requests so this should fix the test as it was meant to test if the dashboards tab behaves correctly based on the admin/read-only role. However, we should think about a solution to those errors in case we have this scenario (read-only user role without apm/streams access) and have a better error message/explanation of what is missing instead of only showing the error toasts - I saw that we reverted (elastic#202418) already a solution (elastic#200151) for APM because of other issues but now that we also include the `streams` (elastic#200060) (not sure if we need to do the request in infra but that's probably a different discussion) it's something we can revisit at one point to improve the user experience.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the Streams app plugin, which renders UI for managing streams (see #198713).
Additional changes in this PR:
@kbn/server-route-repositorywas updated to be able to overrideaccess(instead of only inferring it from the endpoint name). Additionally, we now allow all route options by default.@kbn/typed-react-router-confignow also exports auseBreadcrumbs. This was copied over from the APM implementation.esqlmethod inObservabilityElasticsearchClientwas updated to separate processing options from options that are sent over to the _query endpoint.