-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[8.18] [Security Solution] [AI Assistant] Update copy of the citations tour. (#210398) #212025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elastic#210398) ## Summary Addresses elastic/security-docs#6485 (comment) This PR updates the copy in the Citations and Anonymized values tour according to the figma linked in the issue. Furthermore, the PR includes the logic that disables the "Show anonymized values" and "Show citations" buttons in the assistant settings menu when the conversation does not contain anonymized values or citations respectivly. ### How to test new copy is correct <img width="864" alt="image" src="https://github.com/user-attachments/assets/22bd2671-6d06-4e68-85f5-3c10d9974a4a" /> - Enable feature flag ```yaml # kibana.dev.yml xpack.securitySolution.enableExperimental: ['contentReferencesEnabled'] ``` - Clear the key `elasticAssistant.anonymizedValuesAndCitationsTourCompleted.v8.18` from your local storage if it exists. - Open Security assistant - Ask the assistant a question about your alerts or a KB document, the response should contain anonymized values or a citation. - The tour with the new copy should appear (copy in screenshot above). *the Anonymized values and citations will not appear if the knowledge base tour is currently open. ### How to test assistant settings menu changes: <img width="349" alt="image" src="https://github.com/user-attachments/assets/58e445d7-79c0-46ca-a245-bc2ab90eeb5d" /> - Enable feature flag ```yaml # kibana.dev.yml xpack.securitySolution.enableExperimental: ['contentReferencesEnabled'] ``` - Open Security assistant - In a new conversation, inside the settings menu, the "Show anonymized values" and "Show citations" menu items should be disabled because the conversation is empty and does not contain citations or anonymized values. - Ask the assistant a question about a KB document or Alert. The "Show citations" menu item should become available if the response contains citations. The "Show anonymized values" menu item will become available if the conversation contains replacements. Hovering over the disabled menu item will make a tooltip appear explaining why it is disabled. *Sometimes the conversation will contain replacements but the replacements are not used in the messages. In that case, the anonymized values menu item will not be disabled. This is a known [issue](elastic#208517). ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit b59712f) # Conflicts: # x-pack/platform/packages/shared/kbn-elastic-assistant/impl/assistant/settings/settings_context_menu/settings_context_menu.tsx
9 tasks
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]Module Count
Async chunks
History |
spong
approved these changes
Feb 21, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
main
to8.18
:Questions ?
Please refer to the Backport tool documentation